Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get multicast lock when publishing services on android #22519

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Get multicast lock when publishing services on android #22519

merged 1 commit into from
Sep 10, 2022

Conversation

andy31415
Copy link
Contributor

Issue Being Resolved

Change overview

Android 'publish' does not aquire a multicast lock, effectively disallowing the services from being seen on the network past any temporary "resolve" calls (which do aquire the lock).

Added aquire/release for the multicast lock when registering listeners.

1.0 justification: platform fix.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited
Loading

PR #22519: Size comparison from c17d723 to c44ee0b

Increases (10 builds for bl602, esp32, psoc6, qpg, telink)
platform target config section c17d723 c44ee0b change % change
bl602 lighting-app bl602 (read/write) 1411822 1411830 8 0.0
.text 1067064 1067066 2 0.0
bl602+rpc .text 1098668 1098672 4 0.0
esp32 all-clusters-app c3devkit (read/write) 1787654 1787662 8 0.0
.flash.rodata 257208 257216 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26739034 26739035 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26475657 26475658 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22317612 22317613 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1130004 1130012 8 0.0
.text 577100 577108 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812968 8 0.0
text 574348 574350 2 0.0
lighting-app tlsr9518adk80d text 592478 592480 2 0.0
ota-requestor-app tlsr9518adk80d text 598738 598740 2 0.0
Decreases (4 builds for efr32, esp32, psoc6)
platform target config section c17d723 c44ee0b change % change
efr32 lighting-app BRD4161A+rpc (read/write) 973052 973036 -16 -0.0
.text 819936 819920 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1223522 1223518 -4 -0.0
.flash.text 1223522 1223518 -4 -0.0
m5stack (read/write) 563604 563596 -8 -0.0
.flash.rodata 314328 314320 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21937829 21937828 -1 -0.0
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section c17d723 c44ee0b change % change
bl602 lighting-app bl602 (read/write) 1411822 1411830 8 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067064 1067066 2 0.0
bl602+rpc (read/write) 1457282 1457282 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098668 1098672 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676159 676159 0 0.0
(read/write) 175248 175248 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89383 89383 0 0.0
.text 586464 586464 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640879 640879 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78535 78535 0 0.0
.text 562024 562024 0 0.0
lock-ftd LP_CC2652R7 (read only) 677235 677235 0 0.0
(read/write) 164484 164484 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77235 77235 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 660219 660219 0 0.0
(read/write) 177188 177188 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102515 102515 0 0.0
.text 557224 557224 0 0.0
pump-app LP_CC2652R7 (read only) 686071 686071 0 0.0
(read/write) 156352 156352 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90263 90263 0 0.0
.text 595324 595324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670563 670563 0 0.0
(read/write) 171972 171972 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85819 85819 0 0.0
.text 584264 584264 0 0.0
shell LP_CC2652R7 (read only) 666986 666986 0 0.0
(read/write) 179940 179940 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85994 85994 0 0.0
.text 580676 580676 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587394 587394 0 0.0
.app_xip_area 464052 464052 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593146 593146 0 0.0
.app_xip_area 465020 465020 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 477996 477996 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1109992 1109992 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971568 971568 0 0.0
BRD4161A+rpc (read/write) 973052 973036 -16 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819936 819920 -16 -0.0
BRD4161A+rs911x (read/write) 1003432 1003432 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832180 832180 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150916 1150916 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996576 996576 0 0.0
window-app BRD4161A (read/write) 1101224 1101224 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 961336 961336 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223522 1223518 -4 -0.0
(read/write) 1787654 1787662 8 0.0
.dram0.bss 76952 76952 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257208 257216 8 0.0
.flash.text 1223522 1223518 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233347 1233347 0 0.0
(read/write) 563604 563596 -8 -0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314328 314320 -8 -0.0
.flash.text 1227963 1227963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux all-clusters-app debug (read only) 3048137 3048137 0 0.0
(read/write) 156064 156064 0 0.0
.bss 61824 61824 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275787 275787 0 0.0
.text 2592914 2592914 0 0.0
all-clusters-minimal-app debug (read only) 2883953 2883953 0 0.0
(read/write) 147664 147664 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275979 275979 0 0.0
.text 2431314 2431314 0 0.0
bridge-app debug+rpc (read only) 2381769 2381769 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204648 204648 0 0.0
.text 2014210 2014210 0 0.0
chip-tool debug (read only) 10959809 10959809 0 0.0
(read/write) 657736 657736 0 0.0
.bss 26072 26072 0 0.0
.data 2690 2690 0 0.0
.data.rel.ro 622456 622456 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 570485 570485 0 0.0
.text 8868100 8868100 0 0.0
chip-tool-ipv6only arm64 (read only) 10332012 10332012 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 500092 500092 0 0.0
.text 8178852 8178852 0 0.0
lighting-app debug+rpc (read only) 2607193 2607193 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221488 221488 0 0.0
.text 2214514 2214514 0 0.0
lock-app debug (read only) 2590177 2590177 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238480 238480 0 0.0
.text 2184754 2184754 0 0.0
ota-provider-app debug (read only) 2367433 2367433 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210456 210456 0 0.0
.text 1993218 1993218 0 0.0
ota-requestor-app debug (read only) 2532761 2532761 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 217280 217280 0 0.0
.text 2142578 2142578 0 0.0
shell debug (read only) 2616697 2616697 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235986 235986 0 0.0
.text 2222002 2222002 0 0.0
thermostat-no-ble arm64 (read only) 2365844 2365844 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141452 141452 0 0.0
.text 1986304 1986304 0 0.0
tv-app debug (read only) 3200385 3200385 0 0.0
(read/write) 258392 258392 0 0.0
.bss 168152 168152 0 0.0
.data 4144 4144 0 0.0
.data.rel.ro 79520 79520 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260712 260712 0 0.0
.text 2749282 2749282 0 0.0
tv-casting-app debug (read only) 5518105 5518105 0 0.0
(read/write) 160888 160888 0 0.0
.bss 52120 52120 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 100488 100488 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 346097 346097 0 0.0
.text 4899698 4899698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455224 2455224 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417868 1417868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182027 1182027 0 0.0
bss 143641 143641 0 0.0
rodata 143740 143740 0 0.0
text 815708 815708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161227 0 0.0
bss 142868 142868 0 0.0
rodata 135332 135332 0 0.0
text 804100 804100 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1744108 1744108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221909 1221909 0 0.0
.debug_aranges 111776 111776 0 0.0
.debug_frame 373172 373172 0 0.0
.debug_info 26739034 26739035 1 0.0
.debug_line 3662824 3662824 0 0.0
.debug_loc 3581159 3581159 0 0.0
.debug_ranges 340544 340544 0 0.0
.debug_str 3428604 3428604 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571087 571087 0 0.0
.symtab 421776 421776 0 0.0
.text 1544336 1544336 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1687316 1687316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213748 1213748 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 376252 376252 0 0.0
.debug_info 26475657 26475658 1 0.0
.debug_line 3683364 3683364 0 0.0
.debug_loc 3568796 3568796 0 0.0
.debug_ranges 339160 339160 0 0.0
.debug_str 3417609 3417609 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535561 535561 0 0.0
.symtab 408368 408368 0 0.0
.text 1488280 1488280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1604548 1604548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048567 1048567 0 0.0
.debug_aranges 103424 103424 0 0.0
.debug_frame 346520 346520 0 0.0
.debug_info 21937829 21937828 -1 -0.0
.debug_line 3253793 3253793 0 0.0
.debug_loc 3267090 3267090 0 0.0
.debug_ranges 304632 304632 0 0.0
.debug_str 3222875 3222875 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468860 468860 0 0.0
.symtab 375456 375456 0 0.0
.text 1413744 1413744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642236 1642236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1056002 1056002 0 0.0
.debug_aranges 104096 104096 0 0.0
.debug_frame 349348 349348 0 0.0
.debug_info 22317612 22317613 1 0.0
.debug_line 3262602 3262602 0 0.0
.debug_loc 3306957 3306957 0 0.0
.debug_ranges 307976 307976 0 0.0
.debug_str 3250296 3250296 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475063 475063 0 0.0
.symtab 378640 378640 0 0.0
.text 1446400 1446400 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130004 1130012 8 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577100 577108 8 0.0
lock-app qpg6105+debug (read/write) 1101008 1101008 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548108 548108 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812968 8 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574348 574350 2 0.0
lighting-app tlsr9518adk80d (read/write) 834872 834872 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592478 592480 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843116 843116 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598738 598740 2 0.0

@tcarmelveilleux tcarmelveilleux merged commit 8af13a2 into project-chip:master Sep 10, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Get multicast lock when publishing services on android (project-chip#…
8ea1d9e 
…22519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not pass the [TC-DD-2.1] in Android platform
3 participants
@andy31415 @tcarmelveilleux @chrisdecenzo